Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support lustre client #447

Merged
merged 35 commits into from
Oct 30, 2024
Merged

Support lustre client #447

merged 35 commits into from
Oct 30, 2024

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Oct 4, 2024 •
edited
Loading

  • Enables building an "extra" image including a lustre client.
  • Lustre client is built from source so will have OFED support.
  • Automatically selects interface for Lnet configuration based on MGS NID.
  • Only supports tcp Lnets

sjpb and others added 21 commits October 4, 2024 09:52
@sjpb
WIP: add lustre role
e1bdb58
@sjpb
allow definition of multiple lustre_mounts
410e0ed
@sjpb
fix lustre build for 2.15.5 release candidate
9f47321
@sjpb
simplify lustre defaults
63840ee
@sjpb
allow lustre install during build to get kernel version
02b9ae1
@sjpb
allow extending fat images with site-specific groups
8df4a61
@sjpb
fix packer build so only roles for defined groups run
3840baa
@sjpb
enable control of 'extra' build image name
ed8f79b
@sjpb
bump to release lustre
9f04b48
@sjpb
add lnet configuration
28a8297
@sjpb
simplify lustre mount logic
6d5da54
@sjpb
provide lnet config
22be72c
@sjpb
autodetermine lustre interface
e59b2be
@sjpb
WIP: validation needs fixing for lustre_mounts removal
32e3bda
@sjpb
add working lnet.conf template
37d727a
@sjpb
refactor lustre role for multiple mounts, selectable lnet label
5506876
@sjpb
remove unneeded comments from lustre taskfiles
2becb3a
@sjpb
fix lustre net type
2819fc3
@sjpb
fixup opensearch install permissions
75b20fa
@sjpb
add docs for extra builds
023c030
@sjpb
Merge branch 'main' into upstream-lustre
325889b
@sjpb
Copy link
Collaborator Author

sjpb commented Oct 4, 2024

Testing image build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/11180817601

@sjpb sjpb marked this pull request as ready for review October 4, 2024 13:27
@sjpb sjpb requested a review from a team as a code owner October 4, 2024 13:27
@sjpb
Copy link
Collaborator Author

sjpb commented Oct 4, 2024

Test image build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/11181281999

@sjpb
Copy link
Collaborator Author

sjpb commented Oct 4, 2024

Test image build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/11181427999

sd109
sd109 previously approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@sd109 sd109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ansible/roles/lustre/tasks/install.yml Show resolved Hide resolved
@sjpb
Copy link
Collaborator Author

sjpb commented Oct 11, 2024

build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/11291367324

@sjpb sjpb mentioned this pull request Oct 24, 2024
Open
@sjpb
Copy link
Collaborator Author

sjpb commented Oct 24, 2024

Tested it can build a lustre "extra" image using either RL9 or RL9-OFED CI images at this commit.

@sjpb
Copy link
Collaborator Author

sjpb commented Oct 24, 2024

Build to test we haven't broken CI: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/11501463626

@sjpb
Copy link
Collaborator Author

sjpb commented Oct 24, 2024

Build to test this hasn't broken CI: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/11501525129

@sjpb sjpb closed this Oct 24, 2024
@sjpb sjpb reopened this Oct 24, 2024
@sjpb
Copy link
Collaborator Author

sjpb commented Oct 24, 2024

Build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/11501605073

@sjpb sjpb requested a review from sd109 October 25, 2024 15:12
@sjpb sjpb mentioned this pull request Oct 25, 2024
Merged
sd109
sd109 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@sd109 sd109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit f7e7760 into main Oct 30, 2024
6 checks passed
@sjpb sjpb deleted the upstream-lustre branch October 30, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sd109 sd109 sd109 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjpb @sd109