Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add squid role #401

Merged
merged 10 commits into from
Jun 27, 2024
Merged

Add squid role #401

merged 10 commits into from
Jun 27, 2024

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Jun 21, 2024

  • Adds a squid role to allow nodes without direct access to download packages etc.
  • Changes proxy role defaults to set proxy automatically if squid enabled.
  • Fixes idempotency off systemd config from proxy role.

Squid here is from the dnf packages and is not containerised. This avoids a dependency on the podman role, which otherwise might mean only the control node could run squid (as the control node requires podman). Given the stability of squid this seems a reasonable trade-off.

@sjpb
Copy link
Collaborator Author

sjpb commented Jun 21, 2024

@sjpb
Copy link
Collaborator Author

sjpb commented Jun 21, 2024

@sjpb sjpb marked this pull request as ready for review June 21, 2024 13:53
@sjpb sjpb requested a review from a team as a code owner June 21, 2024 13:53
@sjpb sjpb requested a review from sd109 June 21, 2024 13:53
sd109
sd109 previously approved these changes Jun 27, 2024
Copy link
Member

@sd109 sd109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM, just some very minor nit picking comments.

ansible/roles/squid/README.md Outdated Show resolved Hide resolved
ansible/roles/squid/README.md Outdated Show resolved Hide resolved
ansible/roles/squid/README.md Outdated Show resolved Hide resolved
ansible/roles/squid/templates/squid.conf.j2 Outdated Show resolved Hide resolved
environments/common/inventory/group_vars/all/proxy.yml Outdated Show resolved Hide resolved
sjpb and others added 5 commits June 27, 2024 12:30
@sjpb sjpb merged commit 3602dc9 into main Jun 27, 2024
1 check passed
@sjpb sjpb deleted the squid branch June 27, 2024 13:24
MaxBed4d pushed a commit that referenced this pull request Oct 15, 2024
* add squid role + config

* make systemd proxy config idempotent (and clearer)

* fix defaults for squid/builder

* bump CI image

* fix squid cache dir definition error

* Fix squid README nits

Co-authored-by: Scott Davidson <[email protected]>

* Fix squid README nits

Co-authored-by: Scott Davidson <[email protected]>

* Fix squid README nits

Co-authored-by: Scott Davidson <[email protected]>

* Fix squid README nits

Co-authored-by: Scott Davidson <[email protected]>

* make proxy default to squid port

---------

Co-authored-by: Scott Davidson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants