Support HTML elements as textures when DOM/canvas are available #87
Conversation
Benjamin-Dobell
force-pushed
the
master
branch
3 times, most recently
from
7286c51
to
e807bbc
Compare
| } | ||
| } | ||
|
|
||
| if (context !== null) { |
There was a problem hiding this comment.
looks like this if should be moved inside the previous if where the context variable is defined?
There was a problem hiding this comment.
@gre Whoops, quite right. Originally I had the context variable declaration outside the outer if statement but moved it just before submitting the pull request.
Force push incoming...
Benjamin-Dobell
force-pushed
the
master
branch
from
e807bbc
to
94ccafc
Compare
|
@mikolalysenko what do you think of this feature? should we merge this? I think it's great for more interoperability stuff, I actually need it for some tests :) |
| var context = null | ||
|
|
||
| if (typeof pixels.getContext === 'function') { | ||
| context = canvas.getContext('2d') |
There was a problem hiding this comment.
Whoops, don't merge yet.
This should be pixels not canvas on this line.
Benjamin-Dobell
force-pushed
the
master
branch
from
94ccafc
to
d641e79
Compare
|
Alright just force pushed a fix. |
|
Sorry for not reviewing this sooner. Looks good to me! |
|
Could someone publish a new version for this so we don't have to reference git? |
No description provided.