Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional chaining to 'name' in getExtension #238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yuval-a
Copy link

@yuval-a yuval-a commented Oct 21, 2022

This fixes a bug when a name can be 'null' and an exception will be thrown when calling 'getSupportedExtensions()'. This happened to me when using 'gpu.js' - which has this as a dependency. |

This fixes a bug when a name can be 'null' and an exception will be thrown when calling 'getSupportedExtensions()'.
This happened to me when using 'gpu.js' - which has this as a dependency.
|
@dhritzkiv
Copy link
Member

Hi @yuval-a.

Do you know under which circumstances getExtension is called without a value? Calling getExtension without an argument may be a bug in your code.

@yuval-a
Copy link
Author

yuval-a commented Oct 21, 2022 via email

@dhritzkiv
Copy link
Member

Hmm. I cannot reproduce this myself, even after installing gpu.js. I'm running this in nodejs on macOS. What about you?

In either case, I would suggest debugging this problem further by stepping through the code to find what calls getExtension with a non-string argument. I believe this to be a problem elsewhere, and may be indicative of a different sort of bug, possibly somewhere else in headless-gl.

@yuval-a
Copy link
Author

yuval-a commented Oct 22, 2022 via email

@dhritzkiv
Copy link
Member

Could be.

Still, it would helpful for you to step through the code and find where getExtension is being called without a string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants