Extension: OES_standard_derivatives #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dhritzkiv
force-pushed
the
bhouston-OES_standard_derivatives
branch
from
612db84
to
dff2566
Compare
…ly not integrated with ANGLE's extension system properly.
…t enabled Formatting
To pass a conformance test. The incorrect behaviour might be present in our version of angle. FWIW, other extensions, when not enabled, report as defined.
dhritzkiv
force-pushed
the
bhouston-OES_standard_derivatives
branch
from
7fe1a47
to
679d8c4
Compare
robertleeplummerjr
approved these changes
Jan 19, 2020
AlexVestin
reviewed
Feb 27, 2020
It would have not run if webgl_draw_buffers was enabled
remove trailing spaces (introduced from GitHub's editor)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrection of #72
Closes #169
Closes #72
Adds the use of dFdy, dFdx, and fwidth functions, as well as the FRAGMENT_SHADER_DERIVATIVE_HINT constant.
All tests are passing.
Only issue I came across is
GL_OES_standard_derivativesseems to be defined globally (in Angle?), when the extension is not enabled. In order to pass the tests, this is dealt with in_wrapShader, seemingly without any side-effects.