Fix macOS CI by pinning NODE_VERSION to 12.13.0 #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this work for 12.13.1+? |
|
@robertleeplummerjr not yet. I'm still working on the solution to that. |
|
@robertleeplummerjr I updated the issue #180 with information about what's causing the breakage in 12.13.1+ and what may happen in the future to fix the issue. Just thought you'd like to know for your projects |
mourner
approved these changes
Jan 2, 2020
Add section about platform and node version support, including a note about current Node.js breakage on macOS; Other tidying up of the README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves macOS CI for the time being, as a quick fix.
There seemed to be 2 issues with macOS builds: