-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support of node < 8 #159
Conversation
node 8 is the oldest currently supported version. Building on node 5 (and possibly 6) causes certain nan/v8 calls to fail.
@@ -14,5 +14,5 @@ PACKAGE_JSON_VERSION=$(node -e "console.log(require('./package.json').version)") | |||
|
|||
if [[ ${COMMIT_MESSAGE} == ${PACKAGE_JSON_VERSION} ]]; then | |||
echo "running prebuild" | |||
node ./node_modules/prebuild/bin.js --all --strip -u ${GITHUB_TOKEN} | |||
node ./node_modules/prebuild/bin.js -t 8.0.0 -t 9.0.0 -t 10.0.0 -t 11.0.0 -t 12.0.0 --strip -u ${GITHUB_TOKEN} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we build for "dev" versions after the stable ones are released? (specifically v9 and v11 here)
Also, does .0.0
act as asterisk (for latest version of that major number) or it really builds for the exact version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about that, especially since node 9 is no longer supported (8 is, under LTS). But I figured that if it works, then there's no sense in really dropping it. 11, while not LTS, is still supported. I'm open to dropping 9 support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as an asterisk, essentially. Ever since node 4, I believe, the node ABI is consistent within major versions. So, building for 10.0.0 is the same as for 10.15.3 (i.e. ABI version is 64)
I'm using the values which are required from here
To do: I will also include electron prebuilds (since we previously offered them) |
For anyone curious, here's the popularity of each prebuilt asset download from 4.2.2: [
{
"name": "gl-v4.2.2-node-v48-darwin-x64.tar.gz",
"downloadCount": 26
},
{
"name": "gl-v4.2.2-node-v47-darwin-x64.tar.gz",
"downloadCount": 4
},
{
"name": "gl-v4.2.2-node-v51-darwin-x64.tar.gz",
"downloadCount": 9
},
{
"name": "gl-v4.2.2-node-v57-darwin-x64.tar.gz",
"downloadCount": 236
},
{
"name": "gl-v4.2.2-node-v59-darwin-x64.tar.gz",
"downloadCount": 35
},
{
"name": "gl-v4.2.2-node-v64-darwin-x64.tar.gz",
"downloadCount": 490
},
{
"name": "gl-v4.2.2-electron-v47-darwin-x64.tar.gz",
"downloadCount": 4
},
{
"name": "gl-v4.2.2-electron-v48-darwin-x64.tar.gz",
"downloadCount": 4
},
{
"name": "gl-v4.2.2-electron-v49-darwin-x64.tar.gz",
"downloadCount": 5
},
{
"name": "gl-v4.2.2-electron-v50-darwin-x64.tar.gz",
"downloadCount": 4
},
{
"name": "gl-v4.2.2-electron-v57-darwin-x64.tar.gz",
"downloadCount": 5
},
{
"name": "gl-v4.2.2-electron-v54-darwin-x64.tar.gz",
"downloadCount": 4
},
{
"name": "gl-v4.2.2-electron-v51-darwin-x64.tar.gz",
"downloadCount": 4
},
{
"name": "gl-v4.2.2-electron-v64-darwin-x64.tar.gz",
"downloadCount": 7
},
{
"name": "gl-v4.2.2-electron-v53-darwin-x64.tar.gz",
"downloadCount": 4
},
{
"name": "gl-v4.2.2-electron-v47-linux-x64.tar.gz",
"downloadCount": 4
},
{
"name": "gl-v4.2.2-electron-v48-linux-x64.tar.gz",
"downloadCount": 4
},
{
"name": "gl-v4.2.2-electron-v49-linux-x64.tar.gz",
"downloadCount": 4
},
{
"name": "gl-v4.2.2-electron-v50-linux-x64.tar.gz",
"downloadCount": 4
},
{
"name": "gl-v4.2.2-electron-v51-linux-x64.tar.gz",
"downloadCount": 4
},
{
"name": "gl-v4.2.2-electron-v53-linux-x64.tar.gz",
"downloadCount": 4
},
{
"name": "gl-v4.2.2-electron-v54-linux-x64.tar.gz",
"downloadCount": 4
},
{
"name": "gl-v4.2.2-electron-v57-linux-x64.tar.gz",
"downloadCount": 4
},
{
"name": "gl-v4.2.2-electron-v64-linux-x64.tar.gz",
"downloadCount": 5
},
{
"name": "gl-v4.2.2-node-v47-linux-x64.tar.gz",
"downloadCount": 6
},
{
"name": "gl-v4.2.2-node-v48-linux-x64.tar.gz",
"downloadCount": 288
},
{
"name": "gl-v4.2.2-node-v51-linux-x64.tar.gz",
"downloadCount": 1011
},
{
"name": "gl-v4.2.2-node-v57-linux-x64.tar.gz",
"downloadCount": 4210
},
{
"name": "gl-v4.2.2-node-v59-linux-x64.tar.gz",
"downloadCount": 205
},
{
"name": "gl-v4.2.2-node-v64-linux-x64.tar.gz",
"downloadCount": 4308
},
{
"name": "gl-v4.2.2-node-v67-linux-x64.tar.gz",
"downloadCount": 318
}
] Take aways:
|
Updates:
†Users stuck on node <8 can pin their version to v4.2.2. |
node 8 is the oldest currently supported version.
Building on node 5 (and possibly 6) causes certain nan/v8 calls to fail. This prevents the build/upload of prebuilt binary artefacts.
Questions: