Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nostr note and nevent embeds #1175

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

benalleng
Copy link
Contributor

@benalleng benalleng commented May 15, 2024

Description

Adds nostr note and nevent embeds through the jump.me embed system, shoutout to @sfr0x for pointing out its existence!

Closes #1170

Screenshots

image

image

image

Additional Context

TODO

  • I need to figure out the scrolling within an iframe issue as I am passing through the scrolling prop which is deprecated
  • I have the height set to a fixed 485px after expansion but again needing to deal with scrolling because of this on long posts

Additional note: the duplicates catch for nevent posts are giving a bunch of false positives, but that can be for a future PR

Checklist

Are your changes backwards compatible? Please answer below:

Did you QA this? Could we deploy this straight to production? Please answer below:

For frontend changes: Tested on mobile? Please answer below:

Did you introduce any new environment variables? If so, call them out explicitly here:

@benalleng

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a link to a nostr note is shared, extract noteid or nevent from url, and embed the note
1 participant