-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foss home page #1058
base: master
Are you sure you want to change the base?
Foss home page #1058
Conversation
This relates to #1056 and is far from being finished. |
Looking great so far! |
Parsing logic should be pretty much ok now. I'll play around with CSS next time to make things look nice. Probably should try to make it look a bit like the header of stacker.news... |
…lors matching choices from global.scss
WalkthroughThe update enhances the FOSS project with a revamped Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
I've put this as ready for review, as I am not fully sure if this is what you had in mind. Let me know if this is not the proper way to get feedback, for instance, if it is better to discuss this at the I can make additional changes as required, just let me know :) Depending on your feedback, I can eventually also proceed with uploading it to github pages (I did create the project already for that, but have kept it empty for now). |
I tested, these coderabbit suggestions, don't break anything. Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
How are you previewing this while developing it? It doesn't load the files for me when I open the file in the browser. I think it might be worth |
|
I'd say either in the issue or mentioning me with a question while this is in draft is probably the best "I'm not sure" move. I'm going to pop this into draft and monitor it in case you have any questions. |
…or README and docs tabs.
Caught up with my job until an hour ago. I've replaced the FETCH calls with direct readings (using iframe) of the HTML files generated from the Markdown files. That way, you can open the Indeed, my suggestion, in case you're ok with what you see in this browser viewable HTML version, is that I create a new PR, but for the project associated with Github pages where I push the What do you think? |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | Generic Private Key | 31aad62 | docker/cln/client-key.pem | View secret | |
- | Generic Private Key | 31aad62 | docker/cln/server-key.pem | View secret | |
- | Generic Private Key | 31aad62 | docker/cln/ca-key.pem | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Seems like the |
My only "concern" is that I might not want to host The simplest way to do this might be to create a script in If making the build script is too big of a lift, feel free to proceed with the github pages version, and I'll open up another issue for the "build" phase. |
Description
Screenshots
Additional Context
Really just getting familiar with all of this.
This closes #1056
Checklist
Summary by CodeRabbit