Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a link to a nostr note is shared, extract noteid or nevent from url, and embed the note #1170

Open
huumn opened this issue May 14, 2024 · 6 comments · May be fixed by #1175
Open

When a link to a nostr note is shared, extract noteid or nevent from url, and embed the note #1170

huumn opened this issue May 14, 2024 · 6 comments · May be fixed by #1175
Labels
difficulty:medium feature new product features that weren't there before nostr

Comments

@huumn
Copy link
Member

huumn commented May 14, 2024

No description provided.

@huumn huumn added feature new product features that weren't there before difficulty:medium nostr labels May 14, 2024
@benalleng
Copy link
Contributor

For some reference I know that Primal uses noteId vs what appears to be the more standard nEvent so we would likely need to have at least 2 ways to recognize a nostr note

These two links lead to the same event
https://primal.net/e/note1prrgyfue7xxaazapa3lg3p568tpd8883hnunta0ddvmu5ptljyhs2quhg8

https://snort.social/nevent1qqsq335zy7vlrrw73ws7cl5gs6dr4sknnncme7f47hkkkd72q4leztcpr9mhxue69uhhyetvv9ujuumwdae8gtnnda3kjctv9upzqpxfzhdwlm3cx9l6wdzyft8w8y9gy607tqgtyfq7tekaxs7lhmxfqvzqqqqqqyh0nfrc

Do you have any design ideas on how you might want the embed styled?

@huumn
Copy link
Member Author

huumn commented May 14, 2024

It doesn't need to be too fancy. So, no no design ideas.

@sfr0xyz
Copy link

sfr0xyz commented May 15, 2024

Njump's website widget <script src="https://njump.me/embed/<nip-19-entity>" /> might be handy for this. It creates an embed from any NIP-19 entity.

@benalleng
Copy link
Contributor

I'll check it out! I rolled my own from standard nostr-tools functions but I'll see if this is better for us

@benalleng
Copy link
Contributor

Still have some stypling to do but WoW!
image
@sfr0xyz Definitely want to pay you half of this PR, I would have been working on this for ages had I not known about this njump embed!

@sfr0xyz
Copy link

sfr0xyz commented May 15, 2024

Looks great!

Thanks a lot! Very glad I could help.

@benalleng benalleng linked a pull request May 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:medium feature new product features that weren't there before nostr
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants