Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set the macOS runner in the CI to use macOS 13 #194

Merged
merged 6 commits into from
Jul 24, 2024

Conversation

fm7-1
Copy link
Contributor

@fm7-1 fm7-1 commented Jul 6, 2024

This PR solves issue #193 by setting the macOS version to 13, which is still based on x86.

@fm7-1 fm7-1 requested a review from CristhianMotoche July 6, 2024 01:35
@fm7-1
Copy link
Contributor Author

fm7-1 commented Jul 6, 2024

Hello @CristhianMotoche, I've opened this PR to fix the error with the build. Some additional effort will be required to make it work with macOS 14, so I think the solution for now would be to use version 13. Would you mind taking a look, please?

Copy link
Collaborator

@CristhianMotoche CristhianMotoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CristhianMotoche CristhianMotoche merged commit d494c19 into stackbuilders:main Jul 24, 2024
7 checks passed
@CristhianMotoche
Copy link
Collaborator

@all-contributors add @fm7-1 for code

Copy link
Contributor

@CristhianMotoche

I've put up a pull request to add @fm7-1! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants