Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(native): Add toBeDisabled #140
base: main
Are you sure you want to change the base?
feat(native): Add toBeDisabled #140
Changes from 13 commits
5a8f357
3dbcce9
4146337
512f251
190ce45
39ff2b3
3f36d19
7e87056
543b776
72efbf8
7dd25a0
89ba184
e0cb309
5fbe42a
2aa8928
177eefe
3b3ebc1
898721a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these props still present if the element does not have a parent or children? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're missing tests for
.not.toBeDisabled()
andnot.ToBeEnabled()
. The messaging is different, so having some unit tests is good. I'd test them together with the not inverted test cases to make things simpler, check thecore
package for examples 🙂