Skip to content

fix: Don't print Superset admin credentials during startup #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Apr 11, 2024

Description

Fixes https://github.com/stackabletech/internal-issues/issues/85

First commit is just making script better readable in k8s.
Actual fix is wrapping the command leaking the credentials with set +x and set -x.

Ideally we want a test for this, but I don't know how to test this (other than grepping for the password in the logs)

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@sbernauer sbernauer requested a review from maltesander April 11, 2024 11:37
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer enabled auto-merge April 11, 2024 11:41
@sbernauer sbernauer added this pull request to the merge queue Apr 11, 2024
Merged via the queue into main with commit 08ff6cb Apr 11, 2024
30 checks passed
@sbernauer sbernauer deleted the fix/dont-print-admin-credentials branch April 11, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants