fix: Don't print Superset admin credentials during startup #483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/stackabletech/internal-issues/issues/85
First commit is just making script better readable in k8s.
Actual fix is wrapping the command leaking the credentials with
set +x
andset -x
.Ideally we want a test for this, but I don't know how to test this (other than grepping for the password in the logs)
Definition of Done Checklist
Author
Reviewer
Acceptance