Skip to content

fix: Rename Service port name from superset to http #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 11, 2023
Merged

fix: Rename Service port name from superset to http #394

merged 3 commits into from
Aug 11, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Aug 10, 2023 •
edited by lfrancke
Loading

Description

Fixes #248

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@sbernauer sbernauer changed the title Rename Service port name from superset to http for consistency reasons fix: Rename Service port name from superset to http Aug 10, 2023
@sbernauer sbernauer self-assigned this Aug 10, 2023
maltesander
maltesander approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Aug 11, 2023
Merged via the queue into main with commit cef750e Aug 11, 2023
@sbernauer sbernauer deleted the fix/port-name branch August 11, 2023 06:27
@lfrancke lfrancke added release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. release/23.11.0 labels Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@sbernauer sbernauer

Labels
release/23.11.0 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename exposed service port
3 participants
@sbernauer @maltesander @lfrancke