[Merged by Bors] - Bugfix for: Druid connection not established #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhennig
changed the title
maltesander
reviewed
May 3, 2022
siegfriedweber
force-pushed
the
bugfix/druid-connection-not-established
branch
from
762926b to
6e9c4f6
Compare
siegfriedweber
approved these changes
May 5, 2022
There was a problem hiding this comment.
Approved as soon as the open comments of @maltesander are done.
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
May 9, 2022
## Description Fixes #174 A test for the bug is found in this PR https://github.com/stackabletech/integration-tests/pull/235 - the DruidConnection controller now watches the ConfigMaps, to be notified if a druid instance that should be connected is deployed; to connect it then. - the DruidConnnection namespaces are also made optional in this PR
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #174
A test for the bug is found in this PR https://github.com/stackabletech/integration-tests/pull/235
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information