This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
Detect IONOS managed Stackable clusters and skip installing releases #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernauer
force-pushed
the
detect-ionos
branch
from
05ad1fd
to
f1ac9a2
Compare
lfrancke
reviewed
Oct 19, 2022
| let deployments = Api::<Deployment>::namespaced(client, "stackable-operators") | ||
| .list(&ListParams::default()) | ||
| .await?; | ||
| for deployment in deployments { |
There was a problem hiding this comment.
This loop sounds like something worth moving into its own method so it can be unit tested.
There was a problem hiding this comment.
My hope would be, that we get some more clear marker (e.g. a label on the stackable-operators Namespace) from the IONOS colleagues and replace this section
|
For the record: Had a quick chat with the IONOS folks. They switched to installing SDP Plattform releases. They will mark us with a label on a Namespace which SDP platform version is installed so we can pick it up and validate if the stack/demo is going to run. |
|
Okay, let me know when that has happened and I can put it on the board. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch demos can't be installed on IONOS managed Stackable clusters.
Now it's a best-effort job as the demo might work with the operator versions of the managed stackable.
Maybe we should discuss the Platform release strategy in combination with managed stackable
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information