Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Use S3 structs from the operator-rs framework #55

Closed
wants to merge 22 commits into from
Closed

[Merged by Bors] - Use S3 structs from the operator-rs framework #55

wants to merge 22 commits into from

Conversation

razvan
Copy link
Member

@razvan razvan commented Apr 26, 2022 •
edited by adwk67
Loading

Description

Fixes #49

TODO: release operator-rs 0.18.0 and update Cargo.toml files.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@razvan razvan linked an issue Apr 26, 2022 that may be closed by this pull request
Refactor S3 configuration to be compabitle with ADR and operator-rs implementation #49
Closed
@soenkeliebau soenkeliebau changed the title Patch operator-rs dependency for local testing. Include S3 structs into framework Apr 27, 2022
@razvan razvan changed the title Include S3 structs into framework Use S3 structs from the operator-rs framework Apr 29, 2022
@razvan razvan marked this pull request as ready for review April 29, 2022 12:44
@razvan razvan requested review from fhennig and adwk67 and removed request for fhennig May 4, 2022 13:14
adwk67
adwk67 reviewed May 4, 2022
View reviewed changes
docs/modules/ROOT/pages/usage.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/usage.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/usage.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/usage.adoc Outdated Show resolved Hide resolved
adwk67
adwk67 approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razvan
Copy link
Member Author

razvan commented May 5, 2022

bors merge

bors bot pushed a commit that referenced this pull request May 5, 2022
@razvan
Use S3 structs from the operator-rs framework (#55)
9c3ca09 
## Description

Fixes #49 

**TODO**: release operator-rs 0.18.0 and update Cargo.toml files.
@bors
Copy link

bors bot commented May 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Use S3 structs from the operator-rs framework [Merged by Bors] - Use S3 structs from the operator-rs framework May 5, 2022
@bors bors bot closed this May 5, 2022
@bors bors bot deleted the 49-refactor-s3-configuration-to-be-compabitle-with-objectbucketclaims-from-rook branch May 5, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor S3 configuration to be compabitle with ADR and operator-rs implementation
2 participants
@razvan @adwk67