Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow fine-granular resource CPU settings #408

Merged
merged 5 commits into from
May 22, 2024
Merged

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented May 21, 2024

Description

fixes #363.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@adwk67
Copy link
Member Author

adwk67 commented May 21, 2024

Jenkins: ⚠️ https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/133/
All nightly tests pass except logging (which passed locally).

@adwk67 adwk67 marked this pull request as ready for review May 21, 2024 20:04
@adwk67 adwk67 self-assigned this May 22, 2024
@sbernauer sbernauer self-requested a review May 22, 2024 06:58
sbernauer
sbernauer previously approved these changes May 22, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what I was thinking of, awesome!
Change LGTM, I'm currently thinking if we can improve any tests around this 🤔 At least we already have the resources kuttl test :)

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Sebastian Bernauer <[email protected]>
@sbernauer
Copy link
Member

We might want to mark it as breaking in the changelog:

BREAKING: Specified CPU resources are now applied correctly (instead of rounding it to the next whole number). This might affect your jobs, as they now e.g. only have 200m CPU resources available instead of the 1000m it had so far and they might slow down significantly

sbernauer
sbernauer previously approved these changes May 22, 2024
@adwk67
Copy link
Member Author

adwk67 commented May 22, 2024

Yes, good point. Have added note to changelog.

@adwk67 adwk67 enabled auto-merge May 22, 2024 08:24
sbernauer
sbernauer previously approved these changes May 22, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Sebastian Bernauer <[email protected]>
@adwk67 adwk67 added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 436ff43 May 22, 2024
31 of 32 checks passed
@adwk67 adwk67 deleted the fix/resource-granularity branch May 22, 2024 09:14
@lfrancke lfrancke added release/2024-07 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/2024-07 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Container resources are not passed through properly
3 participants