-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow fine-granular resource CPU settings #408
Conversation
Jenkins: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exactly what I was thinking of, awesome!
Change LGTM, I'm currently thinking if we can improve any tests around this 🤔 At least we already have the resources kuttl test :)
Co-authored-by: Sebastian Bernauer <[email protected]>
We might want to mark it as breaking in the changelog: BREAKING: Specified CPU resources are now applied correctly (instead of rounding it to the next whole number). This might affect your jobs, as they now e.g. only have 200m CPU resources available instead of the 1000m it had so far and they might slow down significantly |
Yes, good point. Have added note to changelog. |
Co-authored-by: Sebastian Bernauer <[email protected]>
Description
fixes #363.
Definition of Done Checklist
Author
Reviewer
Acceptance