Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volumeMounts to job pods #359

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Add volumeMounts to job pods #359

merged 5 commits into from
Feb 22, 2024

Conversation

razvan
Copy link
Member

@razvan razvan commented Feb 20, 2024

Description

Fixes #342

Tested with: https://github.com/stackabletech/hdfs-topology-provider/blob/feat/job-volume-mounts/test/stack/07-spark.yaml

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@razvan razvan marked this pull request as ready for review February 21, 2024 15:01
@razvan
Copy link
Member Author

razvan commented Feb 21, 2024

@razvan razvan requested a review from a team February 21, 2024 15:14
@adwk67 adwk67 requested review from adwk67 and removed request for a team February 22, 2024 07:59
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice!

@adwk67
Copy link
Member

adwk67 commented Feb 22, 2024

ah, we probably need an update to the "CRD specification" in the docs section.

Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add this option to the docs/CRD section.

@razvan
Copy link
Member Author

razvan commented Feb 22, 2024

Need to add this option to the docs/CRD section.

Tthe crd docs are now generated automatically. That's why I added this which is copied to the CRD.

@adwk67
Copy link
Member

adwk67 commented Feb 22, 2024

I mean this, which is independent of the auto-generated docs: https://docs.stackable.tech/home/stable/spark-k8s/crd-reference

@razvan razvan added this pull request to the merge queue Feb 22, 2024
Merged via the queue into main with commit 69c0245 Feb 22, 2024
30 checks passed
@razvan razvan deleted the issue/342 branch February 22, 2024 09:00
@lfrancke lfrancke added the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make volume mounts on the job pod configurable.
3 participants