Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm): support labels in values.yaml #344

Merged
merged 3 commits into from
Jan 29, 2024
Merged

feat(helm): support labels in values.yaml #344

merged 3 commits into from
Jan 29, 2024

Conversation

razvan
Copy link
Member

@razvan razvan commented Jan 26, 2024

@razvan razvan mentioned this pull request Jan 26, 2024
Closed
Techassi
Techassi reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason the labels are not included in roles.yaml and spark-clusterrole.yaml?

@razvan
Copy link
Member Author

razvan commented Jan 29, 2024

Any particular reason the labels are not included in roles.yaml and spark-clusterrole.yaml?

My mistake. I saw they were already there for the service account and assumed they are everywhere. Fixed

@razvan razvan requested a review from Techassi January 29, 2024 11:52
@razvan razvan added this pull request to the merge queue Jan 29, 2024
Merged via the queue into main with commit 3a9f905 Jan 29, 2024
30 checks passed
@razvan razvan deleted the feat/label-templates branch January 29, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@razvan @Techassi