Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-include executor/driver cores in spark-config #302

Merged
merged 12 commits into from
Nov 2, 2023
Merged

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Oct 31, 2023

Description

re-include executor/driver cores in spark-config.
Fixes #300.

CI: 🟢 https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/113/

The resources test has been adapted to confirm that SPARK_EXECUTOR_CORES has been correctly set in the executor pods.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@adwk67 adwk67 marked this pull request as ready for review November 2, 2023 14:28
@adwk67 adwk67 requested a review from a team November 2, 2023 14:28
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adwk67 adwk67 added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit 3eed035 Nov 2, 2023
30 checks passed
@bors bors bot deleted the fix/executor-cores branch November 2, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: reinstate setting for spark.executor.cores
2 participants