Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: Typo in executor cpu limit property #263

Closed
wants to merge 4 commits into from

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jul 18, 2023

Description

Introduced in #256

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer changed the title fix: Typo in exxecutor cpu limit property fix: Typo in executor cpu limit property Jul 18, 2023
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM if integration and getting started tests pass!
Edit: Maybe add changelog entry?

@sbernauer
Copy link
Member Author

getting started script passed, starting kuttl tests...

@sbernauer
Copy link
Member Author

@sbernauer
Copy link
Member Author

bors r+
tests passed

bors bot pushed a commit that referenced this pull request Jul 18, 2023
@bors
Copy link

bors bot commented Jul 18, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title fix: Typo in executor cpu limit property [Merged by Bors] - fix: Typo in executor cpu limit property Jul 18, 2023
@bors bors bot closed this Jul 18, 2023
@bors bors bot deleted the fix/executor-cpu-limit-setting branch July 18, 2023 10:28
sbernauer added a commit that referenced this pull request Jul 18, 2023
@lfrancke
Copy link
Member

Same question: This made it into 23.7?

@maltesander
Copy link
Member

Yes this was a bug an was cherry picked into 23.7 branch (other releases were not affected).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants