[Merged by Bors] - feat: Set explicit resources on all containers #249

razvan · 2023-06-06T15:27:38Z

Description

Part of: stackabletech/issues#394

Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

Author

Give feedback

Changes are OpenShift compatible
CRD changes approved
Helm chart can be installed and deployed operator works
Integration tests passed (for non trivial changes)
Options

Reviewer

Give feedback

Code contains useful comments
(Integration-)Test cases added
Documentation added or updated
Changelog updated
Cargo.toml only contains references to git tags (not specific commits or branches)
Options

Acceptance

Give feedback

Feature Tracker has been updated
Proper release label has been added
Options

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

# Conflicts: # CHANGELOG.md

razvan · 2023-06-30T09:17:47Z

Tests almost pass. Will retry the resources test:

--- FAIL: kuttl (1055.12s)
    --- FAIL: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/spark-examples_openshift-true_spark-3.4.0-stackable0.0.0-dev (82.57s)
        --- PASS: kuttl/harness/spark-ny-public-s3_openshift-true_spark-3.4.0-stackable0.0.0-dev_s3-use-tls-true (186.31s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3_openshift-true_spark-3.4.0-stackable0.0.0-dev (147.56s)
        --- PASS: kuttl/harness/logging_openshift-true_spark-3.4.0-stackable0.0.0-dev_ny-tlc-report-0.1.0 (444.98s)
        --- PASS: kuttl/harness/spark-history-server_openshift-true_spark-3.4.0-stackable0.0.0-dev_s3-use-tls-true (287.87s)
        --- PASS: kuttl/harness/spark-pi-public-s3_openshift-true_spark-3.4.0-stackable0.0.0-dev (107.96s)
        --- PASS: kuttl/harness/spark-pi-private-s3_openshift-true_spark-3.4.0-stackable0.0.0-dev (118.64s)
        --- FAIL: kuttl/harness/resources_openshift-true_spark-3.4.0-stackable0.0.0-dev (257.08s)
        --- PASS: kuttl/harness/smoke_openshift-true_spark-3.4.0-stackable0.0.0-dev_s3-use-tls-true (197.46s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3-image_openshift-true_spark-3.4.0-stackable0.0.0-dev_ny-tlc-report-0.1.0 (150.53s)
FAIL

razvan · 2023-06-30T09:49:04Z

Resources test now green too:

--- PASS: kuttl (107.98s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/resources_openshift-true_spark-3.4.0-stackable0.0.0-dev (96.07s)
PASS

Maleware

LGTM! Didn't test it, Docker is currently not working -.-

rust/crd/src/history.rs

razvan · 2023-06-30T10:26:58Z

All tests pass:

--- PASS: kuttl (949.01s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/spark-ny-public-s3_openshift-true_spark-3.4.0-stackable0.0.0-dev_s3-use-tls-true (178.71s)
        --- PASS: kuttl/harness/smoke_openshift-true_spark-3.4.0-stackable0.0.0-dev_s3-use-tls-true (195.18s)
        --- PASS: kuttl/harness/logging_openshift-true_spark-3.4.0-stackable0.0.0-dev_ny-tlc-report-0.1.0 (446.77s)
        --- PASS: kuttl/harness/spark-examples_openshift-true_spark-3.4.0-stackable0.0.0-dev (80.38s)
        --- PASS: kuttl/harness/resources_openshift-true_spark-3.4.0-stackable0.0.0-dev (100.90s)
        --- PASS: kuttl/harness/spark-history-server_openshift-true_spark-3.4.0-stackable0.0.0-dev_s3-use-tls-true (298.60s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3-image_openshift-true_spark-3.4.0-stackable0.0.0-dev_ny-tlc-report-0.1.0 (147.50s)
        --- PASS: kuttl/harness/spark-pi-public-s3_openshift-true_spark-3.4.0-stackable0.0.0-dev (115.56s)
        --- PASS: kuttl/harness/spark-pi-private-s3_openshift-true_spark-3.4.0-stackable0.0.0-dev (113.23s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3_openshift-true_spark-3.4.0-stackable0.0.0-dev (149.03s)
PASS

Maleware

LGTM!

sbernauer

LGTM % ratio comments

rust/crd/src/lib.rs

rust/crd/src/history.rs

tests/templates/kuttl/smoke/04-prepare-bucket.yaml.j2

sbernauer · 2023-07-03T08:09:12Z

Please also update the docs (and maybe kuttl tests) to the new default values.
BTW there are rust test failures

sbernauer

LGTM when kuttl tests pass

razvan · 2023-07-03T10:40:21Z

--- PASS: kuttl (967.88s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/spark-examples_openshift-true_spark-3.4.0-stackable0.0.0-dev (83.53s)
        --- PASS: kuttl/harness/smoke_openshift-true_spark-3.4.0-stackable0.0.0-dev_s3-use-tls-true (206.75s)
        --- PASS: kuttl/harness/spark-ny-public-s3_openshift-true_spark-3.4.0-stackable0.0.0-dev_s3-use-tls-true (182.25s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3_openshift-true_spark-3.4.0-stackable0.0.0-dev (143.34s)
        --- PASS: kuttl/harness/spark-history-server_openshift-true_spark-3.4.0-stackable0.0.0-dev_s3-use-tls-true (297.30s)
        --- PASS: kuttl/harness/resources_openshift-true_spark-3.4.0-stackable0.0.0-dev (100.99s)
        --- PASS: kuttl/harness/spark-pi-public-s3_openshift-true_spark-3.4.0-stackable0.0.0-dev (120.84s)
        --- PASS: kuttl/harness/logging_openshift-true_spark-3.4.0-stackable0.0.0-dev_ny-tlc-report-0.1.0 (451.95s)
        --- PASS: kuttl/harness/spark-pi-private-s3_openshift-true_spark-3.4.0-stackable0.0.0-dev (120.39s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3-image_openshift-true_spark-3.4.0-stackable0.0.0-dev_ny-tlc-report-0.1.0 (153.78s)
PASS

razvan · 2023-07-03T10:40:27Z

bors merge

# Description Part of: stackabletech/issues#394

bors · 2023-07-03T10:48:03Z

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

All tests passed

Add ressource quota to the resources test.

e4e3698

razvan mentioned this pull request Jun 6, 2023

Set explicit resources on all containers stackabletech/issues#394

Closed

razvan added 2 commits June 6, 2023 17:29

Update CHANGELOG.md

b72ab20

Rename resource quota.

f5e3b09

sbernauer changed the title ~~Smoke tests with resource quotas~~ feat: Set explicit resources on all containers Jun 28, 2023

razvan self-assigned this Jun 29, 2023

razvan added 8 commits June 29, 2023 14:28

Merge branch 'main' into feat/resource-quotas

a2628a8

# Conflicts: # CHANGELOG.md

Raise operator-rs version.

b726121

Wip: added smoke tests with limit range and update default res reqs.

955f568

Successful smoke test. Added explicit res reqs to init containers.

7619f83

Yaml lint, Rust fmt, regenerate charts

9c69a21

More Yaml lint

83463ce

Make the resources test pass

df49b17

Update docs

aca9da0

razvan marked this pull request as ready for review June 30, 2023 09:02

razvan requested a review from a team June 30, 2023 09:02

Reduce res requests to avoid cluster exhaustion.

f64da4b

Maleware reviewed Jun 30, 2023

View reviewed changes

rust/crd/src/history.rs Show resolved Hide resolved

Update spark history docs.

e7300a6

razvan requested a review from Maleware June 30, 2023 10:37

Maleware approved these changes Jun 30, 2023

View reviewed changes

sbernauer requested changes Jul 3, 2023

View reviewed changes

rust/crd/src/lib.rs Show resolved Hide resolved

rust/crd/src/lib.rs Show resolved Hide resolved

rust/crd/src/history.rs Show resolved Hide resolved

tests/templates/kuttl/smoke/04-prepare-bucket.yaml.j2 Show resolved Hide resolved

Implement review feedback.

50bf5b6

razvan requested a review from sbernauer July 3, 2023 08:03

razvan added 2 commits July 3, 2023 11:19

Update docs and unit tests.

1bbbd55

Merge branch 'main' into feat/resource-quotas

f4fef55

sbernauer approved these changes Jul 3, 2023

View reviewed changes

bors bot pushed a commit that referenced this pull request Jul 3, 2023

feat: Set explicit resources on all containers (#249)

de7d687

# Description Part of: stackabletech/issues#394

bors bot changed the title ~~feat: Set explicit resources on all containers~~ [Merged by Bors] - feat: Set explicit resources on all containers Jul 3, 2023

bors bot closed this Jul 3, 2023

bors bot deleted the feat/resource-quotas branch July 3, 2023 10:48

lfrancke added the release/2023-07 label Jul 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - feat: Set explicit resources on all containers #249

[Merged by Bors] - feat: Set explicit resources on all containers #249

razvan commented Jun 6, 2023 •

edited by lfrancke

Loading

Author

Reviewer

Acceptance

razvan commented Jun 30, 2023

razvan commented Jun 30, 2023

Maleware left a comment

razvan commented Jun 30, 2023

Maleware left a comment

sbernauer left a comment

sbernauer commented Jul 3, 2023

sbernauer left a comment

razvan commented Jul 3, 2023

razvan commented Jul 3, 2023

bors bot commented Jul 3, 2023

[Merged by Bors] - feat: Set explicit resources on all containers #249

[Merged by Bors] - feat: Set explicit resources on all containers #249

Conversation

razvan commented Jun 6, 2023 • edited by lfrancke Loading

Description

Definition of Done Checklist

Author

Reviewer

Acceptance

razvan commented Jun 30, 2023

razvan commented Jun 30, 2023

Maleware left a comment

Choose a reason for hiding this comment

razvan commented Jun 30, 2023

Maleware left a comment

Choose a reason for hiding this comment

sbernauer left a comment

Choose a reason for hiding this comment

sbernauer commented Jul 3, 2023

sbernauer left a comment

Choose a reason for hiding this comment

razvan commented Jul 3, 2023

razvan commented Jul 3, 2023

bors bot commented Jul 3, 2023

razvan commented Jun 6, 2023 •

edited by lfrancke

Loading