Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Deploy default and support custom affinities #217

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - Deploy default and support custom affinities #217

wants to merge 9 commits into from

Conversation

razvan
Copy link
Member

@razvan razvan commented Feb 23, 2023 •
edited
Loading

Description

Part of stackabletech/issues#323

CI https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/68/

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@razvan razvan mentioned this pull request Feb 23, 2023
Closed
@razvan razvan marked this pull request as ready for review February 23, 2023 17:01
@razvan razvan requested a review from a team February 23, 2023 17:01
sbernauer
sbernauer approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when test passed

rust/crd/src/affinity.rs Outdated Show resolved Hide resolved
docs/modules/spark-k8s/pages/pod_placement.adoc Outdated Show resolved Hide resolved
@razvan
Copy link
Member Author

razvan commented Feb 24, 2023

bors merge

bors bot pushed a commit that referenced this pull request Feb 24, 2023
@razvan @sbernauer
Deploy default and support custom affinities (#217)
613b64c 
# Description

Part of stackabletech/issues#323

CI https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/68/



Co-authored-by: Sebastian Bernauer <[email protected]>
@bors
Copy link

bors bot commented Feb 24, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Deploy default and support custom affinities [Merged by Bors] - Deploy default and support custom affinities Feb 24, 2023
@bors bors bot closed this Feb 24, 2023
@bors bors bot deleted the feat/affinity branch February 24, 2023 11:33
@siegfriedweber siegfriedweber mentioned this pull request Mar 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@razvan @sbernauer