Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix resource limits test #151

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Fix resource limits test #151

wants to merge 6 commits into from

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Sep 30, 2022 •
edited
Loading

Description

Assert resource limits using Pod definitions

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@adwk67 adwk67 changed the title Fix configmap parsing Fix resource limits test Sep 30, 2022
razvan
razvan reviewed Sep 30, 2022
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. But I would start a CI run before merging.

tests/templates/kuttl/resources/10-assert.yaml Outdated Show resolved Hide resolved
@adwk67
Copy link
Member Author

adwk67 commented Sep 30, 2022 •
edited
Loading

lgtm. But I would start a CI run before merging.

Jenkins: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/39

@adwk67 adwk67 marked this pull request as ready for review October 3, 2022 09:31
maltesander
maltesander approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adwk67
Copy link
Member Author

adwk67 commented Oct 3, 2022

bors merge

bors bot pushed a commit that referenced this pull request Oct 3, 2022
@adwk67
Fix resource limits test (#151)
5c82e66 
# Description

Assert resource limits using Pod definitions
@bors
Copy link

bors bot commented Oct 3, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix resource limits test [Merged by Bors] - Fix resource limits test Oct 3, 2022
@bors bors bot closed this Oct 3, 2022
@bors bors bot deleted the fix_configmap_parsing branch October 3, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvan razvan razvan left review comments

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adwk67 @razvan @maltesander