Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Dockerfile and minor improvements #439

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Fix broken Dockerfile and minor improvements #439

merged 2 commits into from
Sep 18, 2024

Conversation

lfrancke
Copy link
Member

This fixes an issue introduced by a past PR (#432). It uses an argument that doesn't exist ("STACKABLE_USER_NAME").

In the course of diagnosing that I stumbled across a few inconsistencies with our "docker-images" Dockerfiles which I am addressing here as well.

  • Updates the Helm version used (not caught by Renovate yet)
  • Sets a build timeout for the build & package phase to two hours (down from the default of 6)
  • Adds the dnf.conf file
  • Adds convenience utilities
  • Adds a few common aliases and a better prompt

This fixes an issue introduced by a past PR (#432). It uses an argument that doesn't exist ("STACKABLE_USER_NAME").

In the course of diagnosing that I stumbled across a few inconsistencies with our "docker-images" Dockerfiles which I am addressing here as well.

- Updates the Helm version used (not caught by Renovate yet)
- Sets a build timeout for the build & package phase to two hours (down from the default of 6)
- Adds the dnf.conf file
- Adds convenience utilities
- Adds a few common aliases and a better prompt
@lfrancke lfrancke self-assigned this Sep 18, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

template/docker/Dockerfile.j2 Show resolved Hide resolved
@lfrancke lfrancke added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 932368c Sep 18, 2024
2 checks passed
@lfrancke lfrancke deleted the fix/groupadd branch September 18, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants