Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Install hadolint in pre-commit workflow #423

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Sep 5, 2024

Part of stackabletech/issues#637

This fixes two things:

  • Install the hadolint binary to be able to run the pre-commit hook
  • Set the default language version of node to system. This fixes issues on NixOS systems.

@Techassi Techassi self-assigned this Sep 5, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Sep 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 5, 2024
@Techassi Techassi added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 55e6947 Sep 5, 2024
2 checks passed
@Techassi Techassi deleted the fix/install-hadolint branch September 5, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants