Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(stackable-telemetry)!: Rename Tracing to Telemetry #932

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Techassi
Copy link
Member

This PR renames Tracing to Telemetry to more appropriately reflect what the type does: constructing subscribers to process different telemetry signals (currently logs and traces).

@Techassi Techassi self-assigned this Dec 18, 2024
@Techassi Techassi marked this pull request as ready for review December 18, 2024 20:33
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait until I'm back. There's no rush on this yet, and I want to know how metrics fit in to this (from memory it is handled a little different, unless we massage the API a bit)

@Techassi
Copy link
Member Author

We'll hold off on this change until @NickLarsenNZ and I can take a look at how metrics will be handled and if they can be incorporated into the Tracing / Telemetry type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: In Review
Development

Successfully merging this pull request may close these issues.

2 participants