Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Make pod overrides usable without roles. #616

Closed
wants to merge 6 commits into from

Conversation

razvan
Copy link
Member

@razvan razvan commented Jul 4, 2023

Required for: stackabletech/spark-k8s-operator#256

  • Make pub_overrides_schema public.
  • Make PodTemplateSpec implement Atomic.
  • Update CHANGELOG.md

@razvan razvan requested review from nightkr and removed request for a team July 5, 2023 13:52
@sbernauer
Copy link
Member

We might want to rename the PR to something like feat: Implement Merge for PodTemplateSpec

Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the description is outdated (you're not Atomic anymore), but the impl looks good to me.

@razvan
Copy link
Member Author

razvan commented Jul 6, 2023

bors merge

bors bot pushed a commit that referenced this pull request Jul 6, 2023
Required for: stackabletech/spark-k8s-operator#256

- Make pub_overrides_schema public.
- Make PodTemplateSpec implement Atomic.
- Update CHANGELOG.md


Co-authored-by: Sebastian Bernauer <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 6, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Make pod overrides usable without roles. [Merged by Bors] - Make pod overrides usable without roles. Jul 6, 2023
@bors bors bot closed this Jul 6, 2023
@bors bors bot deleted the feat/pub-overrides-schema branch July 6, 2023 08:41
bors bot pushed a commit to stackabletech/spark-k8s-operator that referenced this pull request Jul 7, 2023
# Description

Blocked by: stackabletech/operator-rs#616

Part of stackabletech/issues#346



Co-authored-by: Sebastian Bernauer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants