-
-
Notifications
You must be signed in to change notification settings - Fork 6
chore: bump operator rs 0.67 #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went over the changes, and tested it in a local kind cluster, looking good to me.
One thing I noticed was that I got clippy lints when running clippy locally, but we decided to not do anything about these for now (opened stackabletech/product-config#107), and CI didn't find them for some reason
When you open up the files in your IDE they show up as yellow, I would be very happy if we would put the big variants behind a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description
Please add a description here. This will become the commit message of the merge request later.
Definition of Done Checklist
Author
Reviewer
Acceptance