Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nifi 1.25.0 #571

Merged
merged 13 commits into from
Feb 21, 2024
Merged

Support nifi 1.25.0 #571

merged 13 commits into from
Feb 21, 2024

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Feb 8, 2024

Description

  • added nifi 1.25.0
  • refactoring of reporting task into own module
  • refactoring of sensitive key secret & tls into own module
  • new service for reporting task containing a single node is deployed. This was required to fix JWT issues when accessing different nodes with the same JWT
  • the new service is added to the proxy hosts as well as the nifi cert

fixes #558

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@maltesander maltesander requested a review from a team February 8, 2024 17:16
@maltesander maltesander self-assigned this Feb 8, 2024
@maltesander maltesander marked this pull request as ready for review February 20, 2024 09:54
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

rust/operator-binary/src/reporting_task/mod.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/security/tls.rs Outdated Show resolved Hide resolved
@maltesander
Copy link
Member Author

@sbernauer
Copy link
Member

Tests failed because [sh -c kubectl cp -n $NAMESPACE ./test_nifi.py test-nifi-0:/tmp, restarted them: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/nifi-operator-it-custom/53/

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maltesander maltesander added this pull request to the merge queue Feb 21, 2024
Merged via the queue into main with commit 52b8346 Feb 21, 2024
30 checks passed
@maltesander maltesander deleted the support-nifi-1.25.0 branch February 21, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[NEW VERSION] NiFi 1.25.0
3 participants