[Merged by Bors] - Fix processing of log events in Vector #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
siegfriedweber
force-pushed
the
fix-log-events
branch
from
9c7f93d to
2183f66
Compare
maltesander
reviewed
Apr 10, 2023
There was a problem hiding this comment.
No 1970 timestamps but i found some broken logs:
And the operator throws an apply error for the reporting task (i think not related to this PR):
2023-04-10T15:46:25.281021Z ERROR stackable_operator::logging::controller: Failed to reconcile object controller.name="nificluster.nifi.stackable.tech" error=reconciler for object NifiCluster.v1alpha1.nifi.stackable.tech/test-nifi.
default failed error.sources=[failed to apply create ReportingTask job, Kubernetes reported error: ApiError: Job.batch "test-nifi-create-reporting-task-1-18-0" is invalid: spec.template: Invalid value: core.PodTemplateSpec{ObjectMe
ta:v1.ObjectMeta{Name:"test-nifi-create-reporting-task-1-18-0", GenerateName:"" ... field is immutable: Invalid]
bors bot
pushed a commit
that referenced
this pull request
Apr 12, 2023
# Description Fixes bugs found in #452 such as ``` 2023-04-10T15:46:25.281021Z ERROR stackable_operator::logging::controller: Failed to reconcile object controller.name="nificluster.nifi.stackable.tech" error=reconciler for object NifiCluster.v1alpha1.nifi.stackable.tech/test-nifi. default failed error.sources=[failed to apply create ReportingTask job, Kubernetes reported error: ApiError: Job.batch "test-nifi-create-reporting-task-1-18-0" is invalid: spec.template: Invalid value: core.PodTemplateSpec{ObjectMe ta:v1.ObjectMeta{Name:"test-nifi-create-reporting-task-1-18-0", GenerateName:"" ... field is immutable: Invalid] ``` Co-authored-by: Malte Sander <[email protected]>
# Conflicts: # CHANGELOG.md # rust/operator-binary/src/controller.rs
bors bot
pushed a commit
that referenced
this pull request
Apr 13, 2023
# Description - Avoid empty log events dated to 1970-01-01 and improve the precision of the log event timestamps. - Add a test case to detect invalid log events - Make the logging tests independent of the availability of the upstream Vector aggregator. Co-authored-by: Malte Sander <[email protected]>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integration tests
https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/nifi-operator-it-custom/30/
Definition of Done Checklist
Author
Reviewer
Acceptance
Once the review is done, comment
bors r+(orbors merge) to merge. Further information