Skip to content

Conversation

@maltesander
Copy link
Member

@maltesander maltesander commented Nov 7, 2025

Description

depends on stackabletech/docker-images#1340

  • Add operator-rs OpaConfig to CRD
  • Add opa tests to smoke test
    • rego rules allow CREATEs and SELECTS for the existing smoke test
    • added python script to test deny case (database not allowed)
  • Add support for TLS implementation
  • Add new hive - opa example

part of #388

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@maltesander maltesander moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Nov 10, 2025
@dervoeti dervoeti self-requested a review November 13, 2025 07:59
@dervoeti dervoeti moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Nov 13, 2025
@maltesander maltesander requested a review from dervoeti November 17, 2025 15:05
dervoeti
dervoeti previously approved these changes Nov 17, 2025
dervoeti
dervoeti previously approved these changes Nov 18, 2025
@maltesander
Copy link
Member Author

maltesander commented Dec 2, 2025

lfrancke
lfrancke previously approved these changes Dec 2, 2025
Copy link
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at the one commit that came in after the approval from Lukas and that looks good to me.

Copy link
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestion

Comment on lines +88 to +90
# This property *is* required. It changed for derby in version 4.2.0
# which we check in code and add in the ConfigMap builder instead of
# the compute_files() method in crd.rs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# This property *is* required. It changed for derby in version 4.2.0
# which we check in code and add in the ConfigMap builder instead of
# the compute_files() method in crd.rs.
# This property *is* required even though it is set to `false` here.
# The required value changed in Derby in version 4.2.0.
# We now set this value depending on the Hive version (and its corresponding Derby version) and add it to the ConfigMap programatically.

Comment on lines +88 to +90
# This property *is* required. It changed for derby in version 4.2.0
# which we check in code and add in the ConfigMap builder instead of
# the compute_files() method in crd.rs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# This property *is* required. It changed for derby in version 4.2.0
# which we check in code and add in the ConfigMap builder instead of
# the compute_files() method in crd.rs.
# This property *is* required even though it is set to `false` here.
# The required value changed in Derby in version 4.2.0.
# We now set this value depending on the Hive version (and its corresponding Derby version) and add it to the ConfigMap programatically.```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

4 participants