-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Enable opa authorization #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Lukas Krug <[email protected]>
lfrancke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only looked at the one commit that came in after the approval from Lukas and that looks good to me.
lfrancke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor suggestion
| # This property *is* required. It changed for derby in version 4.2.0 | ||
| # which we check in code and add in the ConfigMap builder instead of | ||
| # the compute_files() method in crd.rs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # This property *is* required. It changed for derby in version 4.2.0 | |
| # which we check in code and add in the ConfigMap builder instead of | |
| # the compute_files() method in crd.rs. | |
| # This property *is* required even though it is set to `false` here. | |
| # The required value changed in Derby in version 4.2.0. | |
| # We now set this value depending on the Hive version (and its corresponding Derby version) and add it to the ConfigMap programatically. |
| # This property *is* required. It changed for derby in version 4.2.0 | ||
| # which we check in code and add in the ConfigMap builder instead of | ||
| # the compute_files() method in crd.rs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # This property *is* required. It changed for derby in version 4.2.0 | |
| # which we check in code and add in the ConfigMap builder instead of | |
| # the compute_files() method in crd.rs. | |
| # This property *is* required even though it is set to `false` here. | |
| # The required value changed in Derby in version 4.2.0. | |
| # We now set this value depending on the Hive version (and its corresponding Derby version) and add it to the ConfigMap programatically.``` |
Description
depends on stackabletech/docker-images#1340
OpaConfigto CRDpart of #388
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker