-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(pr_test_build_images): Build changed products on PR #948
Open
NickLarsenNZ
wants to merge
20
commits into
main
Choose a base branch
from
ci/pr-builds
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes no sense, since this workflow is optimised for Pull Requests
… variable, and explain why we can't use the build output
…ges to avoid pointless builds
I have left a note in versions.py to remind people to update versions.toml and explain why there are now two files to maintain.
…uct build workflows)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a workflow to test product images builds based on changed paths.
Some things to note:
versions.toml
(see xxx)build_on_pr
in their respectiveversions.toml
file will be built and pushed.oci.stackable.tech
.-prXXX
suffix, similar to what is done for the operators (eg: oci.stackable.tech/sdp/airflow:2.10.2-stackable0.0.0-dev-pr948)