name in label:classes can be null
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
null is only allowed for raster, right? So I guess we should go one step further and only allow null if |
|
I'm not very familiar with JSON Schema. Is this roughly how it would work? |
jisantuc
reviewed
Aug 20, 2021
cuttlefish
force-pushed
the
fix/labelclasses-name
branch
from
008f9bf
to
1b9f168
Compare
jisantuc
requested changes
Aug 23, 2021
Co-authored-by: James Santucci <[email protected]>
jisantuc
approved these changes
Aug 23, 2021
|
@jisantuc Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unsure if this is correct or not, but it attempts to address #7