Skip to content

Support simulation of date/dateime placeholders #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Support simulation of date/dateime placeholders #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b72ad9
Support simulation of date/dateime placeholders
clxmstaab Feb 4, 2022
b071cff
Update QuerySimulation.php
clxmstaab Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions .phpstan-dba.cache
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions src/QueryReflection/MysqliQueryReflector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ final class MysqliQueryReflector implements QueryReflector

public const MYSQL_HOST_NOT_FOUND = 2002;

public const DATE_FORMAT = 'Y-m-d';

private const MAX_CACHE_SIZE = 50;

/**
Expand Down
5 changes: 4 additions & 1 deletion src/QueryReflection/QuerySimulation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,10 @@ public static function simulateParamValueType(Type $paramType, bool $preparedPar
if ($stringType->isSuperTypeOf($paramType)->yes() || $paramType instanceof ObjectType && $paramType->isInstanceOf(Stringable::class)->yes()) {
// in a prepared context, regular strings are fine
if (true === $preparedParam) {
return '1';
// returns a string in date-format, so in case the simulated value is used against a date/datetime column
// we won't run into a sql error.
// XX in case we would have a proper sql parser, we could feed schema-type-dependent default values in case of strings.
return date(MysqliQueryReflector::DATE_FORMAT);
}

// plain string types can contain anything.. we cannot reason about it
Expand Down
Loading