Skip to content

don't report placeholder errors on non-SELECT statements for now #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2022
Merged

don't report placeholder errors on non-SELECT statements for now #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
841b58c
don't report placeholder errors on non-SELECT statements for now
clxmstaab Jan 19, 2022
a59051d
Update syntax-error-in-prepared-statement.php
clxmstaab Jan 19, 2022
42b3ee0
cs
clxmstaab Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/QueryReflection/PlaceholderValidation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ final class PlaceholderValidation
*/
public function checkErrors(string $queryString, array $parameters): iterable
{
if ('SELECT' !== QueryReflection::getQueryType($queryString)) {
return;
}

$queryReflection = new QueryReflection();
$placeholderCount = $queryReflection->countPlaceholders($queryString);

Expand Down
2 changes: 1 addition & 1 deletion src/QueryReflection/QueryReflection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ public function resolveQueryString(Expr $queryExpr, Scope $scope): ?string
return QuerySimulation::simulateParamValueType($type);
}

private function getQueryType(string $query): ?string
public static function getQueryType(string $query): ?string
{
$query = ltrim($query);

Expand Down
26 changes: 26 additions & 0 deletions tests/data/syntax-error-in-prepared-statement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,4 +173,30 @@ public function arrayParam(Connection $connection)
$query = 'SELECT email FROM ada WHERE adaid IN (:adaids)';
$connection->preparedQuery($query, ['adaids' => [1, 2, 3]]);
}

public function noErrorInBug94(Connection $connection)
{
// XXX with proper sql parsing, we should better detect the placeholders and therefore could validate this query
$sql = "
INSERT IGNORE INTO `s_articles_supplier` (`id`, `name`, `img`, `link`, `changed`) VALUES (:supplierId, 'TestSupplier', '', '', '2019-12-09 10:42:10');
Copy link
Owner Author

@staabm staabm Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the current placeholder parsing detects :42 of the datetime-col as a placeholder


INSERT INTO `s_articles` (`id`, `supplierID`, `name`, `datum`, `taxID`, `changetime`, `pricegroupID`, `pricegroupActive`, `filtergroupID`, `laststock`, `crossbundlelook`, `notification`, `template`, `mode`) VALUES
(:productId, :supplierId, 'SwagTest', '2020-03-20', '1', '2020-03-20 10:42:10', NULL, '0', NULL, '0', '0', '0', '', '0');

INSERT IGNORE INTO `s_order` (`id`, `ordernumber`, `userID`, `invoice_amount`, `invoice_amount_net`, `invoice_shipping`, `invoice_shipping_net`, `ordertime`, `status`, `cleared`, `paymentID`, `transactionID`, `comment`, `customercomment`, `internalcomment`, `net`, `taxfree`, `partnerID`, `temporaryID`, `referer`, `cleareddate`, `trackingcode`, `language`, `dispatchID`, `currency`, `currencyFactor`, `subshopID`, `remote_addr`) VALUES
(:orderId, '29996', 1, 126.82, 106.57, 3.9, 3.28, '2013-07-10 08:17:20', 0, 17, 5, '', '', '', '', 0, 0, '', '', '', NULL, '', '1', 9, 'EUR', 1, 1, '172.16.10.71');

INSERT IGNORE INTO `s_order_details` (`id`, `orderID`, `ordernumber`, `articleID`, `articleordernumber`, `price`, `quantity`, `name`, `status`, `shipped`, `shippedgroup`, `releasedate`, `modus`, `esdarticle`, `taxID`, `tax_rate`, `config`) VALUES
(15315352, :orderId, '20003', :productId, 'SW10178', 19.95, 1, 'Strandtuch Ibiza', 0, 0, 0, '0000-00-00', 0, 0, 1, 19, ''),
(15315353, :orderId, '20003', 177, 'SW10177', 34.99, 1, 'Strandtuch Stripes für Kinder', 0, 0, 0, '0000-00-00', 0, 0, 1, 19, ''),
(15315354, :orderId, '20003', 173, 'SW10173', 39.99, 1, 'Strandkleid Flower Power', 0, 0, 0, '0000-00-00', 0, 0, 1, 19, ''),
(15315355, :orderId, '20003', 160, 'SW10160.1', 29.99, 1, 'Sommer Sandale Ocean Blue 36', 0, 0, 0, '0000-00-00', 0, 0, 1, 19, ''),
(15315356, :orderId, '20003', 0, 'SHIPPINGDISCOUNT', -2, 1, 'Warenkorbrabatt', 0, 0, 0, '0000-00-00', 4, 0, 0, 19, '');
";

$supplierId = '81729';
$productId = 91829002;
$orderId = 15315351;
$connection->preparedQuery($sql, ['orderId' => $orderId, 'productId' => $productId, 'supplierId' => $supplierId]);
}
}