Wildcard Regex pattern for Service Paths #198
Open
+30
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the capabilities to allow a regex based pattern for service paths. Lets you be more flexible for service assignment.
|
Thoughts on this? |
|
Hello there, While considering, but i don't plan to merge this for now. |
|
+1 looks good to me |
|
Any update on this? |
|
This would be a very useful feature! |
Willis1776
added a commit
to Willis1776/websocket-sharp
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the capabilities to allow a regex based pattern for service paths. Lets you be more flexible for service assignment.
You can have websockets that bind to this path:
/report/.*
to allow for websockets that do:
/report/1339481
Lets you be more flexible with your service paths. Default behavior for this change will resort to the previous behavior. Otherwise, if true is passed for using a wildcard service path, you can use any valid regex for your path instead to match what is passed in from the websocket client.