chore: post review fixes and clean up #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
y0sher
commented
Sep 11, 2023
•
y0sher
commented
- Change operators file to load from json
- add Makefile
- cleanup logs
- added some tests that fixed bugs
Threshold (3f+1) and min/max/unique operators
pavelkrolevets
approved these changes
Sep 11, 2023
y0sher
changed the title
pavelkrolevets
added a commit
that referenced
this pull request
Aug 23, 2024
MatusKysel
added a commit
that referenced
this pull request
Sep 3, 2024
* initial resigning * add routes + flow * working resigning with result validation * fix tests * add integration tests for resiging * update integration tests to use cli commands * initial spec alignment + reshare module * working resharing * add EIP1271 owner signature verification * update resharing + add docker demo for resharing * add reshare threshold + integration tests * add threshold integration tests * fix logic at message processing * add eip1271 sig integration tests * add eip1271 sig verification to resign + integration/docker tests * add eip1271 sig resign test + bulk tests * fix/update unit + integration tests * update tests + fix bls set * PR comments resolved #1 * PR comments resolved #2 * PR comments resolved #3 * PR comments resolved #4 * PR comments resolved #5 * PR comments resolved #6 * fix tests + docker build update * update CI * fix test * lint * add more reshare integration tests * go 1.23 * add unit tests for join/disjoin sets of operators * lint * add proofs validation before sending + more reshare threshold integration tests * fix unit tests * lint * fix review comments * remove typo and unused struct --------- Co-authored-by: Matus Kysel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.