Support Delayed Token Update #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
riccardo-ssvlabs
commented
Apr 17, 2025
riccardo-ssvlabs
commented
- Support storage of strategy owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the README documentation to provide instructions on updating module contracts and upgrading the implementation contract. Key changes include:
- Adding a new section to update module contracts on-chain via the proxy contract.
- Introducing a dedicated section for upgrading the implementation contract, including reference to an automation script.
- Retaining existing Public Testnet information for Holesky.
Files not reviewed (19)
- package.json: Language not supported
- scripts/DeployProxy.s.sol: Language not supported
- src/core/SSVBasedApps.sol: Language not supported
- src/core/interfaces/IBasedAppManager.sol: Language not supported
- src/core/interfaces/ICore.sol: Language not supported
- src/core/interfaces/IProtocolManager.sol: Language not supported
- src/core/libraries/CoreStorageLib.sol: Language not supported
- src/core/libraries/ProtocolStorageLib.sol: Language not supported
- src/core/modules/BasedAppsManager.sol: Language not supported
- src/core/modules/ProtocolManager.sol: Language not supported
- src/core/modules/StrategyManager.sol: Language not supported
- src/middleware/interfaces/IBasedApp.sol: Language not supported
- src/middleware/modules/core/BasedAppCore.sol: Language not supported
- test/SSVBasedApps.t.sol: Language not supported
- test/helpers/Setup.t.sol: Language not supported
- test/helpers/Utils.t.sol: Language not supported
- test/modules/BasedAppsManager.t.sol: Language not supported
- test/modules/ProtocolManager.t.sol: Language not supported
- test/modules/StrategyManager.t.sol: Language not supported
Comments suppressed due to low confidence (1)
README.md:155
- [nitpick] The inclusion of the symbol '❍' within the function call may be confusing if not part of the actual identifier. Consider clarifying its purpose or removing it to avoid ambiguity in documentation.
__`❍ updateModules`__: specifying the correct module id and the new module address.
Comment on lines
+67
to
+69
| if (requestTime > tokenData.effectTime) { | ||
| tokenData.currentValue = tokenData.pendingValue; | ||
| } |
There was a problem hiding this comment.
the thing is if you update beta suddenly upwards, lots of over obligations may stop making sense... Because of OBLIGATION_TIMELOCK_PERIOD it will be hard to fix on time.
However the bApp will probably not want to wreck itself so might be fine.
There was a problem hiding this comment.
We just need to set warnings in docs
|
@riccardo-ssvlabs good work!
|
mtabasco
approved these changes
Apr 23, 2025
src/core/SSVBasedApps.sol
Outdated
| return (s.strategies[strategyId].owner, s.strategies[strategyId].fee); | ||
| } | ||
|
|
||
| function strategyOwners( |
There was a problem hiding this comment.
better to change name to strategiesByOwner, ownerStrategies or similar
0xtechdean
reviewed
Apr 23, 2025
| address bApp, | ||
| address token, | ||
| uint256 amount, | ||
| uint32 percentage, |
There was a problem hiding this comment.
Maybe you should consider working with wads instead of percentage
mtabasco
added a commit
that referenced
this pull request
Jun 18, 2025
* Support Delayed Token Update (#40) * Feature deactivation on demand (#42) * feat: update adjust percentage formula and optimizations * Updated deployment scripts (#45) * Release/v0.1.0 (#46) * Fix: Propose Obligation Update (#73) * fix(obligationRequests): set correct storage location * chore: add v0.1.1 fix deployment metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.