Add binary control support #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a buffer containing the binary information needed to control certain devices. It looks like the initial PR for this (ssut#5) was for a unit which supported certain string-based commands – this is not the case with mine and others (per related sampsyo/wideq#12). This is a dynamic method which will build up the binary control string from the specification and current Status object.
This implements a special rti/rtiControl request where the control data is sent as a b64 string, rather than a more standard key/value methodology. See sampsyo/wideq#12 for more information about this spec/request.
The old ones are left as-is (not renamed) for backwards compatibility. In the future, I would recommend prefixing them with "setKey" for clarity. These new methods take advantage of the setDeviceControlBinary methods and control refrigerators that use binary control.
Closed
|
Oops, just realized I left some extra console print statements in there. Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain kinds of equipment use a binary string instead of key/value pairs to set data.
You can see a detailed example in sampsyo/wideq#12. This string is dynamically generated based on the model's information, therefore, is also more natural and easier to use.
As my refrigerator uses these types of commands, I implemented methods of RefrigeratorDevice which take advantage of this control method. The old ones are left as-is (not renamed) for backwards compatibility. In the future, I would recommend prefixing them with "setKey" for clarity. I plan on making a PR to NorDroN/homebridge-wideq soon which allows setting which mode to use (for different kinds of hardware).