Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some i18n support (button labels) #295

Merged
merged 4 commits into from
Jul 27, 2019
Merged

Some i18n support (button labels) #295

merged 4 commits into from
Jul 27, 2019

Conversation

vdh
Copy link
Contributor

@vdh vdh commented Jun 1, 2018

While implementing i18n, I noticed that while I could customise the labels of some of the config, the link buttons, the image button, and the history buttons (undo/redo) were still hardcoded to English values.

Here's a sample config:

const toolbarConfig = {
  // other config…
  LINK_BUTTONS: {
    link: {
      label: linkLabel,
    },
    removeLink: {
      label: removeLinkLabel,
    },
  },
  IMAGE_BUTTON: {
    label: imageButtonLabel,
  },
  HISTORY_BUTTONS: {
    undo: {
      label: undoLabel,
    },
    redo: {
      label: redoLabel,
    },
  },
};

I also replaced the deprecated react-addons-test-utils with react-test-renderer/shallow, and added react and react-dom to devDependencies so they install properly for local development.

@strongui
Copy link

Any chance of getting this merged soon?

@sibelius sibelius merged commit d9e6cc2 into sstur:master Jul 27, 2019
@ArtistHam
Copy link

ArtistHam commented Aug 5, 2019

@sstur @sibelius Could you please add this changes to npm package?

@aleksandr-zheglov
Copy link

aleksandr-zheglov commented Aug 28, 2019

Are you publishing this change to npm ? It would be nice 💯

@vdh vdh deleted the i18n-support branch October 8, 2019 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants