New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache control not set when maxAge is 0 #12

Closed

usaccounts opened this issue Aug 24, 2023 · 1 comment

usaccounts commented Aug 24, 2023 •

edited

Loading

In fileServing.ts:

if (maxAge) {
    headers['Cache-Control'] = `max-age=${maxAge}`;
}

will not set the header as 0 == false
This should be:

if (maxAge == undefined) {
    headers['Cache-Control'] = `max-age=${maxAge}`;
}

The text was updated successfully, but these errors were encountered:

sstur added a commit that referenced this issue


          Fix maxAge (issue #12)

2044c08

Owner

sstur commented Aug 24, 2023

Fixed in v0.13.2

sstur closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment