Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds setting the hardware clock with
setttimeofday()
, such that standard time() functions will work; at least to return UTC time. It felt to me like that should be part of such a library rather than leaving it up to the caller to research/realize this is needed, but some may have different opinion.I was only able to test this on esp8266 at this time, I don't have any reference if this works on other hardware.
Perhaps this should be made optional step, but for me doing this in the
ntpUpdate()
call works for my use case. (I was using theTLog
to log message via syslog and it expects time() to work.)I suppose if it was optional, some might want this to set hardware to localtime; since it happens frequently enough I suppose that'd be good enough for DST changes.