fix(tui): worker path resolution in dev mode #3778

paralin · 2025-11-02T21:22:26Z

Previous versions allowed:

bun install
bun dev ../path/to/my/project

But now I get:

% bun dev ../path/to/my/project
$ bun run --cwd packages/opencode --conditions=browser src/index.ts ../path/to/my/project
Error: Failed to change directory to /Users/cjs/repos/opencode/packages/path/to/my/project

If I try to add more ../ I get:

% bun dev ../../../path/to/my/project
$ bun run --cwd packages/opencode --conditions=browser src/index.ts ../../../path/to/my/project
ErrorEvent {
  type: "error",
  message: "BuildMessage: ModuleNotFound resolving \"./src/cli/cmd/tui/worker.ts\" (entry point)",
  error: null,
}

This commit fixes this by using relative path resolution.

Fixes: #3777

packages/opencode/src/cli/cmd/tui/thread.ts

kommander · 2025-11-03T19:48:43Z

This works as compiled standalone executable and for dev:

diff --git a/packages/opencode/script/build.ts b/packages/opencode/script/build.ts
index 1d3a3fac..4ce8bfba 100755
--- a/packages/opencode/script/build.ts
+++ b/packages/opencode/script/build.ts
@@ -41,7 +41,9 @@ for (const [os, arch] of targets) {
 
   const opentui = `@opentui/core-${os === "windows" ? "win32" : os}-${arch.replace("-baseline", "")}`
   await $`mkdir -p ../../node_modules/${opentui}`
-  await $`npm pack ${opentui}@${pkg.dependencies["@opentui/core"]}`.cwd(path.join(dir, "../../node_modules"))
+  await $`npm pack ${opentui}@${pkg.dependencies["@opentui/core"]}`.cwd(
+    path.join(dir, "../../node_modules"),
+  )
   await $`tar -xf ../../node_modules/${opentui.replace("@opentui/", "opentui-")}-*.tgz -C ../../node_modules/${opentui} --strip-components=1`
 
   const watcher = `@parcel/watcher-${os === "windows" ? "win32" : os}-${arch.replace("-baseline", "")}${os === "linux" ? "-glibc" : ""}`
@@ -49,7 +51,11 @@ for (const [os, arch] of targets) {
   await $`npm pack ${watcher}`.cwd(path.join(dir, "../../node_modules")).quiet()
   await $`tar -xf ../../node_modules/${watcher.replace("@parcel/", "parcel-")}-*.tgz -C ../../node_modules/${watcher} --strip-components=1`
 
-  const parserWorker = fs.realpathSync(path.resolve(dir, "./node_modules/@opentui/core/parser.worker.js"))
+  const parserWorker = fs.realpathSync(
+    path.resolve(dir, "./node_modules/@opentui/core/parser.worker.js"),
+  )
+  const workerPath = "./src/cli/cmd/tui/worker.ts"
+
   await Bun.build({
     conditions: ["browser"],
     tsconfig: "./tsconfig.json",
@@ -61,10 +67,11 @@ for (const [os, arch] of targets) {
       execArgv: [`--user-agent=opencode/${Script.version}`, `--env-file=""`, `--`],
       windows: {},
     },
-    entrypoints: ["./src/index.ts", parserWorker, "./src/cli/cmd/tui/worker.ts"],
+    entrypoints: ["./src/index.ts", parserWorker, workerPath],
     define: {
       OPENCODE_VERSION: `'${Script.version}'`,
       OTUI_TREE_SITTER_WORKER_PATH: "/$bunfs/root/" + path.relative(dir, parserWorker),
+      OPENCODE_WORKER_PATH: workerPath,
       OPENCODE_CHANNEL: `'${Script.channel}'`,
     },
   })
diff --git a/packages/opencode/src/cli/cmd/tui/thread.ts b/packages/opencode/src/cli/cmd/tui/thread.ts
index 3fd998bc..05b4e9a4 100644
--- a/packages/opencode/src/cli/cmd/tui/thread.ts
+++ b/packages/opencode/src/cli/cmd/tui/thread.ts
@@ -8,6 +8,10 @@ import { bootstrap } from "@/cli/bootstrap"
 import path from "path"
 import { UI } from "@/cli/ui"
 
+declare global {
+  const OPENCODE_WORKER_PATH: string
+}
+
 export const TuiThreadCommand = cmd({
   command: "$0 [project]",
   describe: "start opencode tui",
@@ -55,7 +59,11 @@ export const TuiThreadCommand = cmd({
     // Resolve relative paths against PWD to preserve behavior when using --cwd flag
     const baseCwd = process.env.PWD ?? process.cwd()
     const cwd = args.project ? path.resolve(baseCwd, args.project) : process.cwd()
-    const workerPath = new URL("./worker.ts", import.meta.url).href
+    let workerPath = new URL("./worker.ts", import.meta.url).href
+
+    if (typeof OPENCODE_WORKER_PATH !== "undefined") {
+      workerPath = OPENCODE_WORKER_PATH
+    }
 
     try {
       process.chdir(cwd)
@@ -63,6 +71,7 @@ export const TuiThreadCommand = cmd({
       UI.error("Failed to change directory to " + cwd)
       return
     }
+
     await bootstrap(cwd, async () => {
       upgrade()

paralin · 2025-11-04T03:47:14Z

@kommander thanks I updated the PR. it works for me, I tested :)

jerome-benoit · 2025-11-04T08:49:58Z

packages/opencode/src/cli/cmd/tui/thread.ts

+    // Resolve relative paths against PWD to preserve behavior when using --cwd flag
+    const baseCwd = process.env.PWD ?? process.cwd()
+    const cwd = args.project ? path.resolve(baseCwd, args.project) : process.cwd()
+    let workerPath = new URL("./worker.ts", import.meta.url).href


Theoretically, Worker class is able to handle plain URL object. But I guess you hit a bug in bun that is not yet fixed.

I think I have fixed this with 646f4b6

Since you're on it, you should really mention the bun bug URI to explain why that workaround to resolve cwd manually is currently needed

@jerome-benoit squashed it & added the link + explanation

Sorry, I mean in the code comment: so people do not remove it. That code should not be here in normal circumstance and people might remove it because of that. Keeping track of why it's here will reduce that probability ;)

istarkov · 2025-11-04T09:11:34Z

It's a bun bug
here imo is more simple fix #3764
based on comment here oven-sh/bun#15981 (comment)

Easier to delete 2 lines when bun will fix the issue.

jerome-benoit · 2025-11-04T09:15:21Z

It's a bun bug here imo is more simple fix #3764 based on comment here [oven-sh/bun#15981 (comment)]

But it does not address the main concern here.

istarkov · 2025-11-04T09:16:36Z

Ive just tested, it works in dev mode against my own repo and build is working

PS: anyway tested the other command, executing being in repo
PPS: Both are working

jerome-benoit · 2025-11-04T09:44:11Z

Ive just tested, it works in dev mode against my own repo and build is working

Some edge cases are not properly handled by your PR. The code here is trying the resolve cwd to handle most of them (while also consolidating worker files path definition).

istarkov · 2025-11-04T09:57:48Z

Can you provide that edge cases? So I could learn

paralin · 2025-11-04T10:02:26Z

Bun bug: Worker path resolution inconsistency between dev and build modes oven-sh/bun#15981
bun run --cwd packages/opencode, the process.cwd() returns the --cwd value packages/opencode, not the directory the user ran "bun" within. This causes path.resolve(args.project) to resolve relative paths from the wrong base directory.

Uses sst#3778 Signed-off-by: Christian Stewart <[email protected]>

Previous versions allowed: ``` bun install bun dev ../path/to/my/project ``` But now I get: ``` % bun dev ../path/to/my/project $ bun run --cwd packages/opencode --conditions=browser src/index.ts ../path/to/my/project Error: Failed to change directory to /Users/cjs/repos/opencode/packages/path/to/my/project ``` If I try to add more ../ I get: ``` % bun dev ../../../path/to/my/project $ bun run --cwd packages/opencode --conditions=browser src/index.ts ../../../path/to/my/project ErrorEvent { type: "error", message: "BuildMessage: ModuleNotFound resolving \"./src/cli/cmd/tui/worker.ts\" (entry point)", error: null, } ``` This commit fixes this by using relative path resolution. There are actually two bugs fixed here: Bun bug: oven-sh/bun#15981 `bun run --cwd packages/opencode`, the `process.cwd()` returns the `--cwd` value `packages/opencode`, not the directory the user ran "bun" within. This causes `path.resolve(args.project)` to resolve relative paths from the wrong base dir. We can use the URL object directly for worker path in dev mode. Fixes: sst#3777 Co-authored-by: Sebastian Herrlinger <[email protected]> Signed-off-by: Christian Stewart <[email protected]>

Uses sst#3778 Signed-off-by: Christian Stewart <[email protected]>

jerome-benoit · 2025-11-04T10:50:12Z

Can you provide that edge cases? So I could learn

It's a workaround for a code interpreter issue. We do not know what is the root cause in the interpreter: import code path resolution? worker code path resolution? worker env init code? generic path resolution issue (unlikely), ... Since you do not know, enforcing a robust cwd path resolution before is the safest way.

istarkov · 2025-11-04T11:50:08Z

I prefer to focus on an optimistic future. Imagine one day Bun fixes the issue, and all you have to do is remove two lines of code or much more in multiple files. It’s quite debatable whether sharing a variable between the build and the code actually makes things better - in both cases, you still need to search for the source. (It’s shared via define and ts will point you to the globals section.)

import code path resolution? worker code path resolution? worker env init code? generic path resolution issue (unlikely)

We’re just implementing a bug workaround. Both changes are the same, except here the path is shared through define.

In a pessimistic scenario, it’s still easy to detect the issue in any situation I can imagine. The code above doesn’t produce TypeScript or linting errors if the worker is moved.

I absolutely don’t mean to offend - that’s just how I see it. ;-)

jerome-benoit · 2025-11-04T12:25:34Z

I prefer to focus on an optimistic future. Imagine one day Bun fixes the issue, and all you have to do is remove two lines of code or much more in multiple files. It’s quite debatable whether sharing a variable between the build and the code actually makes things better - in both cases, you still need to search for the source. (It’s shared via define and ts will point you to the globals section.)

Tunables single source of truth is a best practice.
Robust workaround implementation dealing with versioning and edge cases is also a best practice.

I prefer to focus on building reliable software following documented best practices elaborated by people smarter than me since computer science has begun.

kommander · 2025-11-04T16:37:55Z

Thanks for both of your contributions! Keep it coming, appreciated.

Uses sst#3778 Signed-off-by: Christian Stewart <[email protected]>

paralin mentioned this pull request Nov 2, 2025

bun dev with different project dir fails #3777

Closed

kommander reviewed Nov 3, 2025

View reviewed changes

packages/opencode/src/cli/cmd/tui/thread.ts Outdated Show resolved Hide resolved

paralin force-pushed the fix-rel-paths branch from 07858eb to b2476a9 Compare November 4, 2025 03:47

paralin force-pushed the fix-rel-paths branch from b2476a9 to beb22cb Compare November 4, 2025 03:48

paralin marked this pull request as ready for review November 4, 2025 03:51

github-actions bot force-pushed the dev branch from 6af2fa7 to d3566d3 Compare November 4, 2025 04:01

paralin force-pushed the fix-rel-paths branch 2 times, most recently from 33efc8d to 1352970 Compare November 4, 2025 05:48

This was referenced Nov 4, 2025

fix: make Worker import cwd-independent (use import.meta.url) #3764

Closed

fix: Fix worker.ts path for production and dev #3660

Draft

jerome-benoit reviewed Nov 4, 2025

View reviewed changes

paralin force-pushed the fix-rel-paths branch 2 times, most recently from 76400b4 to ebb0914 Compare November 4, 2025 10:09

paralin added a commit to paralin/opencode that referenced this pull request Nov 4, 2025

refactor: use --dir positional for workdir

33cff20

Uses sst#3778 Signed-off-by: Christian Stewart <[email protected]>

paralin changed the title ~~fix: bun dev with relative project path~~ fix: tui worker path resolution in dev mode with relative project dir Nov 4, 2025

paralin force-pushed the fix-rel-paths branch from ebb0914 to 2eba385 Compare November 4, 2025 10:19

paralin changed the title ~~fix: tui worker path resolution in dev mode with relative project dir~~ fix(tui): worker path resolution in dev mode Nov 4, 2025

paralin added a commit to paralin/opencode that referenced this pull request Nov 4, 2025

refactor: use --dir positional for workdir

5f015c6

Uses sst#3778 Signed-off-by: Christian Stewart <[email protected]>

kommander merged commit 09bb819 into sst:dev Nov 4, 2025
3 checks passed

paralin added a commit to paralin/opencode that referenced this pull request Nov 4, 2025

refactor: use --dir positional for workdir

a26a3af

Uses sst#3778 Signed-off-by: Christian Stewart <[email protected]>

paralin added a commit to paralin/opencode that referenced this pull request Nov 4, 2025

refactor: use --dir positional for workdir

7965523

Uses sst#3778 Signed-off-by: Christian Stewart <[email protected]>

paralin added a commit to paralin/opencode that referenced this pull request Nov 4, 2025

refactor: use --dir positional for workdir

6267980

Uses sst#3778 Signed-off-by: Christian Stewart <[email protected]>

paralin added a commit to paralin/opencode that referenced this pull request Nov 5, 2025

refactor: use --dir positional for workdir

1899b0a

Uses sst#3778 Signed-off-by: Christian Stewart <[email protected]>

paralin added a commit to paralin/opencode that referenced this pull request Nov 5, 2025

refactor: use --dir positional for workdir

48a4728

Uses sst#3778 Signed-off-by: Christian Stewart <[email protected]>

paralin added a commit to paralin/opencode that referenced this pull request Nov 5, 2025

refactor: use --dir positional for workdir

eb761ad

Uses sst#3778 Signed-off-by: Christian Stewart <[email protected]>

paralin added a commit to paralin/opencode that referenced this pull request Nov 5, 2025

refactor: use --dir positional for workdir

76f7980

Uses sst#3778 Signed-off-by: Christian Stewart <[email protected]>

paralin added a commit to paralin/opencode that referenced this pull request Nov 6, 2025

refactor: use --dir positional for workdir

9fd717d

Uses sst#3778 Signed-off-by: Christian Stewart <[email protected]>

paralin added a commit to paralin/opencode that referenced this pull request Nov 6, 2025

refactor: use --dir positional for workdir

e9b23f5

Uses sst#3778 Signed-off-by: Christian Stewart <[email protected]>

fix(tui): worker path resolution in dev mode #3778

fix(tui): worker path resolution in dev mode #3778

Uh oh!

Conversation

paralin commented Nov 2, 2025

Uh oh!

Uh oh!

kommander commented Nov 3, 2025

Uh oh!

paralin commented Nov 4, 2025

Uh oh!

jerome-benoit Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

paralin Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

jerome-benoit Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

paralin Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

jerome-benoit Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

istarkov commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jerome-benoit commented Nov 4, 2025

Uh oh!

istarkov commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jerome-benoit commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

istarkov commented Nov 4, 2025

Uh oh!

paralin commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jerome-benoit commented Nov 4, 2025

Uh oh!

istarkov commented Nov 4, 2025

Uh oh!

jerome-benoit commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kommander commented Nov 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jerome-benoit Nov 4, 2025 •

edited

Loading

istarkov commented Nov 4, 2025 •

edited

Loading

istarkov commented Nov 4, 2025 •

edited

Loading

jerome-benoit commented Nov 4, 2025 •

edited

Loading

paralin commented Nov 4, 2025 •

edited

Loading

jerome-benoit commented Nov 4, 2025 •

edited

Loading