Refactor File.Content to use discriminated union with MIME types #3108
+129
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
File.Content
to a discriminated union for type-safe text vs binaryhandling
cs
Changes
File.Content
with a discriminated union keyed bytype
:text
:{ type: "text", content, diff?, patch? }
binary
:{ type: "binary", content /* base64 */, mimeType }
getMimeType(path)
with common extension map andapplication/octet-strea m
fallbackisBinaryFile(path, file)
using extension heuristics plus a null-byte scan of the first up to 512 bytes
read(path)
:binary
with base64 content andmimeType
for detected binariestext
content; when tracked in git, computediff
and fullpatch
(tries unstaged, then staged)
FileContent
as a discriminated unionBenefits
ver and SDK
mimeType
metadata enables correct client-side rendering and processing
text
variant; binary is base64 with metadatacontent.type
discriminator