docs: fix Ctrl+K styling in documentation #3021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't "Ctrl + K" be more explicit ? |
|
@ZiedYousfi Yeah, I can do that. Some other variants: 
|
|
I feel like both of those are good but maybe the first one would be less visually overwhelming imo |
|
@ZiedYousfi I agree the first one in #3021 (comment) is best. |
|
Yeah the first version looks good, here's what it looks like on the Mac: 
|
|
@jayair The screenshot is without my fix applied, right? |
|
@jayair @ZiedYousfi Here's the newest version: |
kmk142789
approved these changes
Oct 12, 2025
|
Yeah this looks good, but let's drop the border on the individual characters. Thanks! |
Remove border and padding from kbd elements, adjust Cmd symbol line-height
|
@jayair Done. 
|
rekram1-node
changed the title
|
gonna merge since jay said it looked good |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Edit:
After discussion, settled on this version:
(Mac)
(PC)
Tested on:
Chrome: Version 136.0.7103.92 (Official Build) (64-bit)
Mozilla Firefox 140.0.4
(Linux)