no check if unzip is installed

[iislamgom3a]

[github-actions]

This issue might be a duplicate of existing issues. Please check:

• feat: Replace unzip with PowerShell's built-in extraction for zip archives #967: This issue specifically addresses replacing the external unzip dependency with PowerShell's built-in extraction capabilities to eliminate the 'choco install unzip' dependency requirement

Feel free to ignore if none of these address your specific case.

[vickywane]

@rekram1-node I'd love to work on this.

Should unzip be automatically installed if not found?

Cc: @thdxr

[rekram1-node]

@vickywane Instead of automatically installing unzip, I'm thinking we should fall back to using tar when unzip isn't available.

[vickywane]

Okay, that sounds like a good idea.

I can work on a PR to implement that.

[vickywane]

@rekram1-node I've fixed this in this PR

[rekram1-node]

@vickywane btw your fix doesn't fix this issue unfortunately

This is an issue w/ the install script, I was saying it should fall back to tar (if it doesn't, maybe this was fixed since issue was made):

opencode/install

Line 97 in afb406c

unzip -q "$filename"

For what you did in your PR that is actually really good BUT we need to actually do a slightly different solution for windows compat

We actually have a separate issue tracking what you tried to fix: #967

We want to replace all unzip invocations in lsp install with zip js

[vickywane]

Oh, I see @rekram1-node

I just went through the link issue, and I don't think it's fixed. ( The PR was closed.)

If the expectation is to use zip.js, would it be safe to assume it'll be used for both Windows and Unix platforms? Would you also like me to continue with the PR to achieve this?

[rekram1-node]

yes @vickywane that pr was closed because the llm didnt understand the goal haha

And yes using zipjs is compatible on both platforms

Btw dont feel pressured to open a pr but if you are happy to ill give some guidance:

• we already use zipjs in a few other places
• when using zipjs with the lsps be careful to preserve symlinks and things
• should be pretty easy to test the changes:

clear the bin dir that lsps are installed in then:
bun run dev debug lsp diagnostics

^ should install lsp if not installed

[vickywane]

Haha

I'm happy to give it a shot!

Will read through the existing usages of zip.js

(Thanks for the suoerfast responses btw)

[rekram1-node]

ofc!