Skip to content
This repository has been archived by the owner on Oct 27, 2024. It is now read-only.

Refine windows platform configuration #77

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Refine windows platform configuration #77

merged 2 commits into from
Jun 14, 2024

Conversation

cavivie
Copy link
Collaborator

@cavivie cavivie commented Jun 13, 2024 •
edited
Loading

  • Move wintun_path to wintun_file, which makes the options clearer.
  • Use Into<OsString> instead of &str, which is consistent with libloading so that platform native strings can be passed.
  • Replace optional argument of the method dns_servers to an inner actual value.

@cavivie cavivie requested a review from ssrlive June 13, 2024 15:17
@ssrlive ssrlive merged commit 78985e6 into ssrlive:v2 Jun 14, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ssrlive ssrlive Awaiting requested review from ssrlive

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cavivie @ssrlive