Skip to content
This repository has been archived by the owner on Oct 27, 2024. It is now read-only.

chore!: refine windows platform configuration #76

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

cavivie
Copy link
Collaborator

@cavivie cavivie commented Jun 13, 2024

Closes 75.

@cavivie cavivie marked this pull request as draft June 13, 2024 12:16
@cavivie cavivie requested a review from ssrlive June 13, 2024 12:22
@cavivie cavivie marked this pull request as ready for review June 13, 2024 12:22
@ssrlive ssrlive merged commit 8ec27d1 into ssrlive:v2 Jun 13, 2024
3 checks passed
@cavivie
Copy link
Collaborator Author

cavivie commented Jun 13, 2024

I don't understand why the .dll ext needs to be removed here?

@ssrlive
Copy link
Owner

ssrlive commented Jun 13, 2024

It can be automatically added by the LoadLibraryExW function.

@cavivie
Copy link
Collaborator Author

cavivie commented Jun 13, 2024

In this case, I prefer to say wintun_path here is wintun_file to make it clearer that wintun is just a filename or a filename with an extension, because wintun looks too much like a path due to the function name is called wintun_path, which will lead users to use wintun path(directory). What do you think?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom loading of wintun.dll should be a feature
2 participants